goto / compass / 10503808764
84%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 76
Run time 5min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 84.069% (-1.1%) from 85.175%
10503808764

push

github

web-flow 
feat: create delete assets API (#77)

* feat(proto): generate proto regarding delete assets

* feat(asset): add refreshed_at field

* feat: create translator from query expr to SQL query and ES query

* feat(module): add expr-lang/expr module

* feat(docs): add comments in QueryExprTranslator

* feat(asset): change migration update

* feat(asset): add down migration

* feat(translator): mark as private func for func that only used in translator

* feat: create delete assets API by query expr

* refactor: make interface for query expr and implement to postgresql and elasticsearch

* refactor: resolve all lint issues

* fix: add refreshed_at in insert asset query

* feat: add refreshed_at field in get all assets

* fix: update return error in delete assets

* fix: update asynchronous process in deletion assets

* refactor: fix lint issues

* feat: fix ConditionalNode logic and toString format

* refactor: remove redundant code, and make return error as soon as possible

* feat: update mock using mockery

* feat: equalize current time at created_at and updated_at based on refreshed_at both in postgresql and elasticsearch

* refactor: rename var

* refactor: remove unused go module

* test: fix existing unit tests

* test: fix existing unit tests

* refactor: makes codes to more readable

* test: create unit test for deletion API

* test: create unit test for converter

* feat: add validation in deletion query and remove redundant code

* feat: make can equals (==) or IN for type and service in delete asset expr

* test: create unit test for delete asset expr

* feat: change flow of deletion assets and refactor codes based on feedbacks

* test: fix unit test

* test: fix unit test

* refactor: remove unused comment

* feat: make maxAttemptRetry to be configurable and improve code performance

* feat: make cancel for context, and remove pointer in ESExpr and SQLExpr

* refactor: make c... (continued)

562 of 762 new or added lines in 14 files covered. (73.75%)

1 existing line in 1 file now uncovered.

6876 of 8179 relevant lines covered (84.07%)

21.68 hits per line

New Missed Lines in Diff

Lines Coverage ∆ File
2
91.68
 -0.03% internal/server/v1beta1/asset.go
2
54.12
 0.79% internal/store/elasticsearch/discovery_repository.go
2
83.14
 0.4% internal/store/postgres/lineage_repository.go
7
92.06
 -2.33% core/asset/service.go
10
75.0
 core/asset/delete_asset_expr.go
20
64.29
 pkg/queryexpr/query_expr.go
34
78.22
 -2.11% internal/store/postgres/asset_repository.go
42
74.23
 pkg/queryexpr/sql_expr.go
81
65.53
 pkg/queryexpr/es_expr.go

Uncovered Existing Lines

Lines Coverage ∆ File
1
78.22
 -2.11% internal/store/postgres/asset_repository.go
Jobs
ID Job ID Ran Files Coverage
1 10503808764.1 76
84.07
 GitHub Action Run
Source Files on build 10503808764