10487545721
92%

Ran 21 Aug 2024 09:59AM UTC

Jobs 1

Files 163

Run time 1min

Badge

Embed ▾

Committed 21 Aug 2024 09:48AM UTC coverage: 90.211% (+0.02%) from 90.189%

Build # 10487545721

Build Type

push

github

Committed by

web-flow

Commit Message

fix: extract page breaks from .docx files (#8232)

* fix: extract page breaks from .docx files

Context: Currently, DOCXToDocument does not extract page breaks from
word documents. This makes it impossible to do things like split by page
or get correct page number metadata after using something like
DocumentSplitter. For example, if you split by word, the 'page_number'
metadata field will be 1 for all documents.

Solution: Added a method to DOCXToDocument that extracts page breaks
from word documents as '\f' characters so that they are recognized by
DocumentSplitter.

Caveat: Due to the way the python-docx library is set up, you can only
accurately determine the location of the first page break for a given
paragraph. In the rare case that a paragraph contains more than one page
break (which means it is an extremely long paragraph spanning multiple
pages), the 2nd, 3rd, etc. page break locations are not known. To sort
of fix this, I just appended the page break characters to the end of
the paragraph text to keep the overall page number values for the
document consistent.

* Apply suggestions from code review

---------

Co-authored-by: Madeesh Kannan <shadeMe@users.noreply.github.com>

Run Details

6976 of 7733 relevant lines covered (90.21%)

0.9 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	10487545721.1	21 Aug 2024 09:59AM UTC	163	90.21	GitHub Action Run

deepset-ai / haystack / 10487545721
92%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 10487545721

deepset-ai / haystack / 10487545721 92%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 10487545721

deepset-ai / haystack / 10487545721
92%

README BADGES
x