SAP / ui5-webcomponents-react / 10486440378

89%

push

github

refactor(FilterBar): remove reference copying of filter/input elements (#6214)

BREAKING CHANGE: The `FilterBar` component was completely overhauled and references of input elements aren’t copied to the filters dialog anymore, also internal logic for reordering and selection has been removed, meaning it’s necessary to control their values manually (e.g. via React state).

BREAKING CHANGE: `onToggleFilters`: The `detail` property of the event now only includes `visible` and `nativeDetail` properties. `filters` and `search` have been removed.

BREAKING CHANGE: `onFiltersDialogSave`: The `detail` property of the event now only includes `selectedFilterKeys`, `reorderedFilterKeys` and `nativeDetail` properties. `elements`, `toggledElements`, `filters`, `search`, `orderIds` have been removed.

BREAKING CHANGE: `onFiltersDialogCancel`: The event is now a callback instead of a `Ui5CustomEvent`. It implements the `escPressed` parameter.

BREAKING CHANGE: `onFiltersDialogClose`: The event is now a callback instead of a `Ui5CustomEvent`. It implements the `closeTrigger` parameter.

BREAKING CHANGE: `onFiltersDialogSelectionChange`: The event is now a callback instead of a `Ui5CustomEvent`. It implements a payload object as parameter.

BREAKING CHANGE: `onFiltersDialogSearch`: The event is now a standard `Input` `onInput` event. The `detail` properties `value` and `element` have been removed.

BREAKING CHANGE: `onClear`: The event is now a standard `ToolbarButton` `onClick` event. The `detail` properties `filters` and `search` have been removed.

BREAKING CHANGE: `onGo`: The event is now a standard `ToolbarButton` `onClick` event. The `detail` properties `elements`, `filters`, `search`, `nativeDetail` have been removed.


BREAKING CHANGE: `onRestore`: The event is now a callback instead of a `CustomEvent`. It implements a payload object as parameter.

BREAKING CHANGE: `onFiltersDialogOpen (TypeScript)`: The target of the event is now a `Toolba... (continued)

2769 of 3747 branches covered (73.9%)

116 of 119 new or added lines in 3 files covered. (97.48%)

4962 of 5714 relevant lines covered (86.84%)

72931.16 hits per line