c-ares / c-ares / 10474323574

92%

push

github

htable: FNV1a: honor offset basis

The FNV1a implementation used in the hashtable threw away the
algorithm's offset basis in preference of the seed value to
ensure different instances of the hashtable produced different
output for the same keys to prevent against hash collision
attacks.

Throwing away the offset basis completely could lead to some
non-uniformity, so instead we are now XORing the seed and the
algorithm-defined offset basis as the new offset basis to use
which should rectify this.

In the current c-ares use cases, this will probably have little
to no impact, but future hash table uses may benefit from the
better distribution.

Authored-By: Brad House (@bradh352)

2 of 2 new or added lines in 1 file covered. (100.0%)

20124 of 21965 relevant lines covered (91.62%)

12824.61 hits per line