oemof / oemof-solph / 10473118052

83%

Build Type

push

github

Committed by web-flow

Commit Message

Merge pull request #1080 from oemof/revision/replace-constraint-tests

Replaces lp diff constraint tests by granular unit tests for functionality.

Reasoning:
- The LP files depend on Pyomo internals, thus they change when Pyomo changes things.
- They include tests for stuff from multiple parts of the code. For example, if I change the constraint formulation for the Bus, every constraint test needs to be rewritten, not only the one for the Bus.
- They are hard to understand (for many) and failed tests are hard to fix. The latter is particularly because of the undefined order of lines, so that just looking at a diff will not tell the difference: Constraints might be in a different order but still the same.

These unit tests still use Pyomo but the results are independent from the back-end. They are rather easy to understand (rather trivial test examples), and even internal constraint formulations can be changed without breaking the test, so it really tests for the specified functionally not the implementation.

Run Details

1177 of 1369 branches covered (85.98%)

Branch coverage included in aggregate %.

131 of 142 new or added lines in 10 files covered. (92.25%)

183 existing lines in 7 files now uncovered.

2471 of 2747 relevant lines covered (89.95%)

2.7 hits per line