stacklok / minder / 10453673588

53%

push

github

Use nil evaluation state if there is no previous evaluation (#4197)

The rule engine has a copy of the previous evaluation state as part of
its context. Prior to this PR, if there is no previous state for a
rule/entity pair, an empty struct would be passed around. This requires
each part of the code which uses the previous state (particularly
remediations and alerts) to test if the fields in the state struct are
the default value. This problem was highlighted in PR #4089 when the
types of some the fields changed, requiring the code to be changed to
have different default checks.

This PR changes the logic so that a nil pointer is returned if there is
no existing state. This makes the check for a lack of previous state to
be consistent irrespective of the fields needed or their type.

@rdimitrov ran smoke tests locally to validate.

1 of 26 new or added lines in 5 files covered. (3.85%)

12792 of 23750 relevant lines covered (53.86%)

45.81 hits per line