10452957617

Committed 19 Aug 2024 12:04PM UTC coverage: 46.827% (-0.1%) from 46.944%

Build # 10452957617

Build Type

push

github

Committed by

web-flow

Commit Message

Allow optional signature when registering notifications (#1797)

This adapts the `POST` `/v2/register/notifications` endpoint to make the `accessToken` optional and, if not present, register for notifications as a non-owner/delegate with no `signer_address` saved. When notifications are dispatched, if no `signer_address` is present, only "public" notifications are therefore dispatch to the related Firebase token:

- Make `notification_subscriptions['signer_address']` column nullable
- Allow upsertion of subscriptions without a signer address, adapting the logic to first clear the subscription if the signer address matches or is undefined in order to "align" subscriptions.
- Add/adjust tests accordingly.

Run Details

476 of 2900 branches covered (16.41%)

Branch coverage included in aggregate %.

6 of 19 new or added lines in 5 files covered. (31.58%)

7 existing lines in 4 files now uncovered.

4557 of 7848 relevant lines covered (58.07%)

12.51 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

90.32

/src/datasources/transaction-api/transaction-api.manager.ts

import { Inject, Injectable } from '@nestjs/common';
import { IConfigurationService } from '@/config/configuration.service.interface';
import { CacheFirstDataSource } from '@/datasources/cache/cache.first.data.source';
import {
  CacheService,
  ICacheService,
} from '@/datasources/cache/cache.service.interface';
import { HttpErrorFactory } from '@/datasources/errors/http-error-factory';
import {
  INetworkService,
  NetworkService,
} from '@/datasources/network/network.service.interface';
import { TransactionApi } from '@/datasources/transaction-api/transaction-api.service';
import { Chain } from '@/domain/chains/entities/chain.entity';
import { IConfigApi } from '@/domain/interfaces/config-api.interface';
import { ITransactionApiManager } from '@/domain/interfaces/transaction-api.manager.interface';
import { ILoggingService, LoggingService } from '@/logging/logging.interface';

@Injectable()
export class TransactionApiManager implements ITransactionApiManager {
  private transactionApiMap: Record<string, TransactionApi> = {};

  private readonly useVpcUrl: boolean;

  constructor(
    @Inject(IConfigurationService)
    private readonly configurationService: IConfigurationService,
    @Inject(IConfigApi) private readonly configApi: IConfigApi,
    private readonly dataSource: CacheFirstDataSource,
    @Inject(CacheService) private readonly cacheService: ICacheService,
    private readonly httpErrorFactory: HttpErrorFactory,
    @Inject(NetworkService) private readonly networkService: INetworkService,
    @Inject(LoggingService) private readonly loggingService: ILoggingService,
  ) {
    this.useVpcUrl = this.configurationService.getOrThrow<boolean>(
      'safeTransaction.useVpcUrl',
    );
  }

  async getApi(chainId: string): Promise<TransactionApi> {
    const transactionApi = this.transactionApiMap[chainId];
    if (transactionApi !== undefined) return transactionApi;

    const chain: Chain = await this.configApi.getChain(chainId);
    this.transactionApiMap[chainId] = new TransactionApi(
      chainId,
      this.useVpcUrl ? chain.vpcTransactionService : chain.transactionService,
      this.dataSource,
      this.cacheService,
      this.configurationService,
      this.httpErrorFactory,
      this.networkService,
      this.loggingService,
    );
    return this.transactionApiMap[chainId];
  }

  destroyApi(chainId: string): void {
    if (this.transactionApiMap[chainId] !== undefined) {
      delete this.transactionApiMap[chainId];
    }
  }
}

1	import { Inject, Injectable } from '@nestjs/common';	16✔
2	import { IConfigurationService } from '@/config/configuration.service.interface';	16✔
3	import { CacheFirstDataSource } from '@/datasources/cache/cache.first.data.source';	16✔
4	import {	16✔
5	CacheService,
6	ICacheService,
7	} from '@/datasources/cache/cache.service.interface';
8	import { HttpErrorFactory } from '@/datasources/errors/http-error-factory';	16✔
9	import {	16✔
10	INetworkService,
11	NetworkService,
12	} from '@/datasources/network/network.service.interface';
13	import { TransactionApi } from '@/datasources/transaction-api/transaction-api.service';	16✔
14	import { Chain } from '@/domain/chains/entities/chain.entity';
15	import { IConfigApi } from '@/domain/interfaces/config-api.interface';	16✔
16	import { ITransactionApiManager } from '@/domain/interfaces/transaction-api.manager.interface';
17	import { ILoggingService, LoggingService } from '@/logging/logging.interface';	16✔
18
19	@Injectable()
20	export class TransactionApiManager implements ITransactionApiManager {	16✔
21	private transactionApiMap: Record<string, TransactionApi> = {};	16✔
22
23	private readonly useVpcUrl: boolean;
24
25	constructor(
26	@Inject(IConfigurationService)
27	private readonly configurationService: IConfigurationService,	16✔
28	@Inject(IConfigApi) private readonly configApi: IConfigApi,	16✔
29	private readonly dataSource: CacheFirstDataSource,	16✔
30	@Inject(CacheService) private readonly cacheService: ICacheService,	16✔
31	private readonly httpErrorFactory: HttpErrorFactory,	16✔
32	@Inject(NetworkService) private readonly networkService: INetworkService,	16✔
33	@Inject(LoggingService) private readonly loggingService: ILoggingService,	16✔
34	) {
35	this.useVpcUrl = this.configurationService.getOrThrow<boolean>(	16✔
36	'safeTransaction.useVpcUrl',
37	);
38	}
39
40	async getApi(chainId: string): Promise<TransactionApi> {
41	const transactionApi = this.transactionApiMap[chainId];	272✔
42	if (transactionApi !== undefined) return transactionApi;	272✔
43
44	const chain: Chain = await this.configApi.getChain(chainId);	18✔
45	this.transactionApiMap[chainId] = new TransactionApi(	18✔
46	chainId,
47	this.useVpcUrl ? chain.vpcTransactionService : chain.transactionService,	9!
48	this.dataSource,
49	this.cacheService,
50	this.configurationService,
51	this.httpErrorFactory,
52	this.networkService,
53	this.loggingService,
54	);
55	return this.transactionApiMap[chainId];	18✔
56	}
57
58	destroyApi(chainId: string): void {
59	if (this.transactionApiMap[chainId] !== undefined) {	2!
UNCOV 60	delete this.transactionApiMap[chainId];	×
61	}
62	}
63	}

safe-global / safe-client-gateway / 10452957617

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous