safe-global / safe-client-gateway / 10452957617

89%

Build Type

push

github

Committed by web-flow

Commit Message

Allow optional signature when registering notifications (#1797)

This adapts the `POST` `/v2/register/notifications` endpoint to make the `accessToken` optional and, if not present, register for notifications as a non-owner/delegate with no `signer_address` saved. When notifications are dispatched, if no `signer_address` is present, only "public" notifications are therefore dispatch to the related Firebase token:

- Make `notification_subscriptions['signer_address']` column nullable
- Allow upsertion of subscriptions without a signer address, adapting the logic to first clear the subscription if the signer address matches or is undefined in order to "align" subscriptions.
- Add/adjust tests accordingly.

Run Details

476 of 2900 branches covered (16.41%)

Branch coverage included in aggregate %.

6 of 19 new or added lines in 5 files covered. (31.58%)

7 existing lines in 4 files now uncovered.

4557 of 7848 relevant lines covered (58.07%)

12.51 hits per line