c-ares / c-ares / 10442180142

91%

Build Type

push

github

Committed by web-flow

Commit Message

connection handling modularization (#857)

The main purpose of this PR is to modularize the communication library,
and streamline the code paths for TCP and UDP into a single flow. This
will help us add additional flows such as TLS, and also make sure these
communication functions return a known set of error codes so that
additional error codes can be added for new flows in the future.

It also adds a new optional callback of
`ares_set_notify_pending_write_callback()` that will assist in
aggregating data from multiple queries into a single write operation.
This doesn't apply to UDP, but on TCP and especially TLS in the future
this can be a significant win. This is automatically applied for the
Event Thread.

It also fixes a long standing issue if UDP connection became saturated
and started returning `EWOULDBLOCK` or `EAGAIN` it was treated as a
failure. Since this is more inline with the TCP code now, it will wait
on a write event to retry.

Finally there are additional cleanups due to not needing to be able to
retrieve socket errnos all over the place.

Authored-By: Brad House (@bradh352)

Run Details

302 of 373 new or added lines in 11 files covered. (80.97%)

5 existing lines in 5 files now uncovered.

20123 of 21965 relevant lines covered (91.61%)

12820.71 hits per line