skeema / skeema / 10426775637

92%

push

github

MariaDB: handle column compression change in Aug 2024 point releases

Previously, when column compression was used in MariaDB, in SHOW CREATE TABLE
and information_schema this would appear after the column type:
    /*!100301 COMPRESSED*/

However, MariaDB's point releases in August 2024 changed it to use a MariaDB-
specific version gate comment:
    /*M!100301 COMPRESSED*/

This change is present starting in MariaDB 10.5.26, 10.6.19, 10.11.9, 11.1.6,
11.2.5, 11.4.3; and all GA versions 11.5.2+. The root cause appears to be
MDEV-34318 which is https://github.com/MariaDB/server/commit/d60f5c1. This
required a bit of digging to find, since neither the Jira ticket nor the Git
commit message explicitly mentions column compression.

Because this MariaDB server change affects SHOW CREATE TABLE and
information_schema, tables using column compression in these new MariaDB
versions will be unsupported for diff operations in previous versions of
Skeema. This commit fixes handling to depend on the specific point release.

This commit also includes two refactors:

1. Implementation of helpers to make MariaDB point release gating easier to
   handle. Previously, this situation happened regarding collation clauses in
   the November 2022 point releases. That conditional logic, as well as the
   new column compression conditional logic, both use a common abstraction
   to map the minimum affected point release in each major.minor release
   series.

2. Refactor of how column clauses are handled in SHOW CREATE TABLE mimicking
   logic in tengo.Column.Definition. This has been rewritten largely for
   improved readability.

86 of 86 new or added lines in 3 files covered. (100.0%)

9980 of 10702 relevant lines covered (93.25%)

1.11 hits per line