Ouranosinc / xscen / 10422447016
90%

DEFAULT BRANCH: main
Ran
Jobs 8
Files 152
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 72.616%. Remained the same
10422447016

push

github

web-flow 
Take translation out of the build process (#443)

<!-- Please ensure the PR fulfills the following requirements! -->
<!-- If this is your first PR, make sure to add your details to the
AUTHORS.rst! -->
### Pull Request Checklist:
- [x] This PR addresses an already opened issue (for bug fixes /
features)
    - This PR fixes #342
- [x] (If applicable) Documentation has been added / updated (for bug
fixes / features).
- [ ] (If applicable) Tests have been added.
- [x] This PR does not seem to break the templates.
- [x] CHANGELOG.rst has been updated (with summary of main changes).
- [x] Link to issue (:issue:`number`) and pull request (:pull:`number`)
has been added.

### What kind of change does this PR introduce?
* Compiled french translations are now kept within the repo and package.
No need to `make translate` on each clone of the source.
* A new Makefile entry `make checkfrench` ensures that the french
catalog is up-to-date AND that the compiled version is older than the
catalog. See notes.
* The linting CI runs this `checkfrench` so a PR adding translatable
messages cannot be merged if the french translation is not given.

### Does this PR introduce a breaking change?
No.

The only change is for developers. `make translate` needs only to be run
if a translatable message was added, after `make findfrench` was run and
the "xscen.po" file updated with the french translation. So, _exactly_
what the contributing guide says to do.

### Other information:
The date check on `mo` files is weak : a catalog file could have a
modified time changed even tough no real change was done. And (in
theory) a compiled file could have a recent date even though it is not
in sync wit the catalog. However, binary comparion of two `mo` files
taken from the same catalog fails. My guess is that the compilation time
is included in the mo file, and I didn't want to dig deeper. We don't
update the translation catalogs often, so this should ... (continued)

23606 of 32508 relevant lines covered (72.62%)

0.73 hits per line

Jobs
ID Job ID Ran Files Coverage
1 run-Python3.11-conda - 10422447016.1 0
73.86
 GitHub Action Run
2 run-Python3.10-conda - 10422447016.2 0
73.86
 GitHub Action Run
3 run-Python3.12 - 10422447016.3 0
71.4
 GitHub Action Run
4 run-Python3.9 - 10422447016.4 0
71.35
 GitHub Action Run
5 run-Python3.11 - 10422447016.5 0
71.4
 GitHub Action Run
6 run-Python3.12-conda - 10422447016.6 0
73.86
 GitHub Action Run
7 run-Python3.10 - 10422447016.7 0
71.4
 GitHub Action Run
8 run-Python3.9-conda - 10422447016.8 0
73.82
 GitHub Action Run
Source Files on build 10422447016
Detailed source file information is not available for this build.