sapcc / limes / 10417665977

80%

push

github

Add endpoints for commitment conversion (#525)

* Add GET endpoint for commitment conversion

* Allow multiple convertibles to be configured

* Change JSON return name to 'conversions'

* Change GET API to support up and down conversions
Change GET API to POST API to receive and check commitments

* Fix comment for linter

* Remove whitespace

* Revert POST endpoint to GET endpoint
Return empty list when no convertibles found
Introduce parse function for commitment-conversions
Fix documentation

* Change documentation headline to match the GET endpoint

* Use core.Cluster like behavior acquisition
check for Unit on target and source resource

* Move resources to quota_noop for unit tests

* Update internal/api/commitment.go

Co-authored-by: Stefan Majewsky <stefan.majewsky@sap.com>

* Update internal/api/commitment_test.go

Co-authored-by: Stefan Majewsky <stefan.majewsky@sap.com>

* use new API declarations type
use cluster infoForResource method to retrieve the resources

* update documentation

* GetCommitmentConversions: do not use IdentityInV1API at all for now

This was still using renaming in the wrong direction in some places.
Since I will fix this with a larger refactoring soon, leaving this in
would only cause unnecessary confusion.

* GetCommitmentConversions: complete the documentation

* fix test instability

---------

Co-authored-by: Stefan Majewsky <stefan.majewsky@sap.com>

56 of 72 new or added lines in 3 files covered. (77.78%)

4711 of 5936 relevant lines covered (79.36%)

60.19 hits per line