openSUSE / agama / 10416172938

72%

Build Type

push

github

Committed by web-flow

Commit Message

refactor(web): replace NetworkClient with queries (#1519)

Adapt the network management code to use queries instead of
NetworkCient. Related to https://github.com/openSUSE/agama/pull/1439.

Additionally, starts migrating the code to TypeScript and fixes bugs
found by the type system.

---

Reviewers, please note that this ended up being a rather long PR, reason
why is better to not only review the code but also to do manual testing
if possible. Take your time, but any issue out of the scope of state
management / queries migration should be reported as a new issue to be
addressed in a new PBI.

---

Notes for creating follow-up work, 

* Fix WifiConnectionForm to avoid `"error": "Network system error:
Network state error: Connection '<ssid>' already exists"` when
connecting to hidden network that previously failed. In short, we should
either, to drop the configuration created for a failed { hidden: true }
connection or to implement a mechanism to know that such a configuration
already exists and performs an _update_ instead of _add_.
* Review when it's possible to define a gateway and fix the UI
information accordingly
* Check if we can use the type Address from ipaddr package instead of
our own IPAddress type (most probably not)
* Add support for IPv6 since as @jreidinger
[said](https://github.com/openSUSE/agama/pull/1519#discussion_r1714327402)
its usage is becoming more common. Look for `FIXME: IPv6 is not
supported yet.` comments

Run Details

1987 of 2868 branches covered (69.28%)

Branch coverage included in aggregate %.

10 of 10 new or added lines in 2 files covered. (100.0%)

23 existing lines in 2 files now uncovered.

19746 of 27612 relevant lines covered (71.51%)

34.66 hits per line