• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

kubevirt / containerized-data-importer / #4881
49%

Build:
DEFAULT BRANCH: main
Ran 16 Aug 2024 04:04AM UTC
Jobs 1
Files 156
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

16 Aug 2024 03:54AM UTC coverage: 59.19% (+0.01%) from 59.177%
#4881

push

travis-ci

web-flow
feat: Copy labels from source to DataSource (#3377)

* cleanup: Extract label copying logic into common pkg

Extract the label copying logic from populator-base.go into the common
pkg as CopyAllowedLabels func.

Signed-off-by: Felix Matouschek <fmatouschek@redhat.com>

* fix(import-populator): Make copying of labels more robust

Make copying of labels from a prime PVC to the target PVC more robust,
by moving it before rebinding the PV from prime to target. This way we
can ensure the labels are already present once the PVC becomes ready.

Signed-off-by: Felix Matouschek <fmatouschek@redhat.com>

* cleanup: Do not pass labels from DIC to DS anymore

Do not pass labels from a DataImportCron to a DataSource in the
dataimportcron-controller anymore. In the future this will be
handled by the datasource-controller.

Signed-off-by: Felix Matouschek <fmatouschek@redhat.com>

* feat: Copy labels from source to DataSource

Copy labels from the source of a DataSource to the labels of the
DataSource in the datasource-controller.

Signed-off-by: Felix Matouschek <fmatouschek@redhat.com>

* tests: Add e2e tests for copying labels to DataSources

Add e2e tests that cover all scenarios where labels should be copied
from the source of a DataSource to the DataSource itself.

Signed-off-by: Felix Matouschek <fmatouschek@redhat.com>

* feat(dataimportcron-controller): Copy labels to VolumeSnapshots

When using VolumeSnapshots copy the labels found on the source PVC to
the created or an existing VolumeSnapshot.

Signed-off-by: Felix Matouschek <fmatouschek@redhat.com>

---------

Signed-off-by: Felix Matouschek <fmatouschek@redhat.com>

42 of 62 new or added lines in 5 files covered. (67.74%)

10 existing lines in 2 files now uncovered.

16610 of 28062 relevant lines covered (59.19%)

0.65 hits per line

New Missed Lines in Diff

Lines Coverage ∆ File
1
62.44
-0.54% pkg/controller/populators/populator-base.go
2
61.9
0.18% pkg/controller/populators/import-populator.go
8
34.96
1.01% pkg/controller/datasource-controller.go
9
62.07
-0.25% pkg/controller/dataimportcron-controller.go

Uncovered Existing Lines

Lines Coverage ∆ File
3
34.96
1.01% pkg/controller/datasource-controller.go
7
52.63
-9.21% pkg/util/prometheus/prometheus.go
Jobs
ID Job ID Ran Files Coverage
1 #4881.1 16 Aug 2024 04:04AM UTC 156
59.19
Source Files on build #4881
  • Tree
  • List 156
  • Changed 8
  • Source Changed 0
  • Coverage Changed 8
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • f357368b on github
  • Prev Build on main
  • Next Build on main
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2025 Coveralls, Inc