rust-bitcoin / rust-bitcoin / 10407616942

83%

push

github

Merge rust-bitcoin/rust-bitcoin#3155: Extension trait for `Script`

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/08576976650f93912dbd568653c26911bcc9a69e">085769766<a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/3119ade372f40ed94ff5a26b49db09cf9a670a69"> Replace impl blocks with extension traits (Martin Habovstiak)
<a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/b99bdcfdd660787193d1feb5e747cb13b3cb05c3">b99bdcfdd</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/3119ade372f40ed94ff5a26b49db09cf9a670a69"> Format `Script` blocks (Martin Habovstiak)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/b027edffe7c38d2bbdf48daa103ddc60cb457485">b027edffe</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/3119ade372f40ed94ff5a26b49db09cf9a670a69"> Wrap `Script` impl blocks in temporary modules (Martin Habovstiak)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/5a461545c724213fbf6c5f1befcc5fa4977d0e5b">5a461545c</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/3119ade372f40ed94ff5a26b49db09cf9a670a69"> Separate private `Script` methods (Martin Habovstiak)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/27adc09e9fcaf868b3aa55b5dde140203281769a">27adc09e9</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/3119ade372f40ed94ff5a26b49db09cf9a670a69"> Generalize fn params in `define_extension_trait` (Martin Habovstiak)
fcc3cb03f Support non-doc attrs in extension trait macro (Martin Habovstiak)
ca1735f24 Separate POD methods (Tobin C. Harding)

Pull request description:

  This moves methods from `Script` to extension traits in steps that should be easy to follow.

  Moving to `primitives` requires doing the same with `ScriptBuf` so I'm holding off until this approach gets concept ACK (or alternatively someone else can do it :))

  Closes #3161

ACKs for top commit:
  tcharding:
    ACK 08576976650f93912dbd568653c26911bcc9a69e
  apoelstra:
    ACK 08576976650f93912dbd568653c26911bcc9a69e successfully ran local tests

Tree-SHA512: 3768d879e7fd4bab78e3d8cc50e312ffb47

158 of 199 new or added lines in 2 files covered. (79.4%)

19666 of 23648 relevant lines covered (83.16%)

15672.67 hits per line