tarantool / luajit / 10402067899

93%

tarantool/master: 93%

Build Type

push

github

Committed by Buristan

Commit Message

FFI: Turn FFI finalizer table into a proper GC root.

Reported by Sergey Bronnikov.

(cherry picked from commit f5affaa6c)

The previous patch fixes the problem partially because the introduced GC
root may not exist at the start phase of the GC cycle (since it isn't
marked because it is not accessible from any GC root). In that case, the
cdata finalizer table will be collected at the end of the cycle. Access
to the cdata finalizer table exhibits heap use after free. The patch
turns the finalizer table into a proper GC root. Note that the finalizer
table is created at the initialization of the main Lua State instead of
loading the FFI library.

Sergey Bronnikov:
* added the description and the test for the problem

Part of tarantool/tarantool#10199

Reviewed-by: Sergey Kaplun <skaplun@tarantool.org>
Reviewed-by: Maxim Kokryashkin <m.kokryashkin@tarantool.org>
Signed-off-by: Sergey Kaplun <skaplun@tarantool.org>
(cherry picked from commit 4b0f1724c)

Run Details

5673 of 6025 branches covered (94.16%)

Branch coverage included in aggregate %.

26 of 26 new or added lines in 5 files covered. (100.0%)

25 existing lines in 5 files now uncovered.

21639 of 23431 relevant lines covered (92.35%)

2939814.89 hits per line