• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

coryhouse / react-slingshot / 101
92%

Build:
DEFAULT BRANCH: master
Ran 08 Jul 2016 01:33PM UTC
Jobs 3
Files 26
Run time 43s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

pending completion
101

Pull #184

travis-ci

web-flow
Clarifying name and use of React env config.

1. "GLOBALS" is ambiguous, particularly since its only use is to configure the React environment. I don't really see a reason to abstract this at all, as opposed to just inlining the object in the call to `webpack.DefinePlugin`.

2. Clarified the comment on line 25 to indicate that the statement before it sets the build to either mode, not just prod.

Note: There should probably be a comment on line 6 to explain the need to `JSON.stringify` a string. I'm not sure of the reason, so I couldn't add the comment myself.
Pull Request #184: Clarifying name and use of React env config.

452 of 457 relevant lines covered (98.91%)

15.5 hits per line

Jobs
ID Job ID Ran Files Coverage
1 101.1 08 Jul 2016 01:34PM UTC 0
98.91
Travis Job 101.1
2 101.2 08 Jul 2016 01:34PM UTC 0
98.91
Travis Job 101.2
3 101.3 08 Jul 2016 01:33PM UTC 0
98.91
Travis Job 101.3
Source Files on build 101
Detailed source file information is not available for this build.
  • Back to Repo
  • Travis Build #101
  • Pull Request #184
  • PR Base - master (#100)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc