• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

bwillis / versioncake / 164
20%

Build:
DEFAULT BRANCH: master
Ran 18 Apr 2014 12:22AM UTC
Jobs 13
Files 32
Run time 5min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

pending completion
164

push

travis-ci

bwillis
Calling any helper method before set_version fails

The assumption in controller_additions is that the set_version before
filter will be called before anything starts using the helpers, and
before render is called. Because we are just a regular filter, another
controller calling prepend_before_filter can get in front of the setup.
If that filter were to reference any of the helpers, then they will be
nil.  It’s reasonable for this data to be available, because when the
filters are running in Rails the request is present with all the info
to extract the version.

This fix will allow the versioned_request to be instantiated at time of
any of the helper calls or if they are not, to instantiate in the
normal before filter.

Fixes #32

527 of 535 relevant lines covered (98.5%)

88.94 hits per line

Jobs
ID Job ID Ran Files Coverage
1 164.1 (1.9.2, gemfiles/rails3.2.gemfile) 18 Apr 2014 12:22AM UTC 0
97.2
Travis Job 164.1
2 164.2 (1.9.3, gemfiles/rails3.2.gemfile) 18 Apr 2014 12:22AM UTC 0
97.2
Travis Job 164.2
3 164.3 (1.9.3, gemfiles/rails4.0.gemfile) 18 Apr 2014 12:23AM UTC 0
97.38
Travis Job 164.3
4 164.4 (1.9.3, gemfiles/rails4.1.gemfile) 18 Apr 2014 12:22AM UTC 0
98.13
Travis Job 164.4
5 164.5 (2.0.0, gemfiles/rails3.2.gemfile) 18 Apr 2014 12:24AM UTC 0
97.2
Travis Job 164.5
6 164.6 (2.0.0, gemfiles/rails4.0.gemfile) 18 Apr 2014 12:24AM UTC 0
97.38
Travis Job 164.6
7 164.7 (2.0.0, gemfiles/rails4.1.gemfile) 18 Apr 2014 12:24AM UTC 0
98.13
Travis Job 164.7
8 164.8 (2.1.0, gemfiles/rails3.2.gemfile) 18 Apr 2014 12:24AM UTC 0
97.2
Travis Job 164.8
9 164.9 (2.1.0, gemfiles/rails4.0.gemfile) 18 Apr 2014 12:25AM UTC 0
97.38
Travis Job 164.9
10 164.10 (2.1.0, gemfiles/rails4.1.gemfile) 18 Apr 2014 12:26AM UTC 0
98.13
Travis Job 164.10
11 164.11 (ruby-head, gemfiles/rails3.2.gemfile) 18 Apr 2014 12:27AM UTC 0
97.2
Travis Job 164.11
12 164.12 (ruby-head, gemfiles/rails4.0.gemfile) 18 Apr 2014 12:27AM UTC 0
97.38
Travis Job 164.12
13 164.13 (ruby-head, gemfiles/rails4.1.gemfile) 18 Apr 2014 12:27AM UTC 0
98.13
Travis Job 164.13
Source Files on build 164
Detailed source file information is not available for this build.
  • Back to Repo
  • Travis Build #164
  • 0f2d56e5 on github
  • Prev Build on master (#163)
  • Next Build on master (#165)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc