MITLibraries / transmogrifier / 10321542796

99%

push

github

Timx 291 orchestration (#205)

* Class methods to instance methods in base classes

* Update get_valid_title, get_source_link, and get_timdex_record_id to instance methods in Transformer, JSONTransformer, and XMLTransformer classes

* Class methods to instance methods in transformer classes

* Update get_source_link and get_timdex_record_id to instance methods in Aardvark and SpringshareOaiDC classes
* Update corresponding unit tests

* Refactor _transform method

Why these changes are being introduced:
* Refactoring this method fundamentally simplifies the application and allows for the removal of several methods

How this addresses that need:
* Refactor _transform method
* Add generate_derived_fields and get_optional_field_methods methods
* Add get_required_field_names and get_optional_field_names methods to TimdexRecord class

Side effects of this change:
* All transform classes with need to be updated in subsequent commits

Relevant ticket(s):
* https://mitlibraries.atlassian.net/browse/TIMX-291

* Remove get_required_fields method from classes

* Remove get_required_fields method from Transformer, JSONTransformer, and XMLTransformer classes
* Remove unit tests for this method

* Add source_record param to field methods

* Some field methods omitted the source_record param because they delivered static values. This caused issues with the new orchestration so an unused param was added.

* Refactor Transformer methods to use TimdexRecord instance

* Refactor create_dates_and_locations_from_publishers and create_locations_from_spatial_subjects method to use TimdexRecord instances
* Call methods in generate_derived_fields
* Update corresponding unit tests

* Refactor generate_citation method to use TimdexRecord instance

* Refactor generate_citation to use a TimdexRecord instance
* Shift call into generate_derived_fields method
* Update corresponding unit tests

* Refactor MITAardvark.get_rights to instanc... (continued)

96 of 100 new or added lines in 10 files covered. (96.0%)

1652 of 1661 relevant lines covered (99.46%)

0.99 hits per line