2228
88%

Ran 07 Jul 2016 08:51PM UTC

Jobs 5

Files 42

Run time 5min

Badge

Embed ▾

pending completion

Build # 2228

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

Fix flaky test TestPeerRemoveClosedConnection (#433)

Test was failing with:
    <autogenerated>:10: Unexpected log: [Warn]: Failed to add connection
    to peer [{service testService} {process testService-52687} {hostPort
    127.0.0.1:52687} {connID 418} {localAddr 127.0.0.1:52687}
    {remoteAddr 127.0.0.1:54541} {remoteHostPort 127.0.0.1:54541}
    {direction inbound} {error tchannel error ErrCodeNetwork: connection
    is in an invalid state}]

The sequence of events was:
p1 creates a connection c1 to p2
once connection is successful, p1 closes c1

On the remote side, p2 has responded to c1 and is about to
mark it active, but the network connection gets closed before
it has been added to the peer's list. When p2 resumes adding
the connection to the peer list, it's now closed due to the underlying
network connection being closed.

We can fix this issue by issuing a ping, which will ensure that the
remote side has processed the connection and has added it to the
peer list before closing the connection.

Run Details

3922 of 4475 relevant lines covered (87.64%)

18660.79 hits per line

Jobs

ID	Job ID	Ran	Coverage
1	2228.1 (TEST_TIMEOUT_SCALE=20)	07 Jul 2016 08:51PM UTC	86.21	Travis Job 2228.1
2	2228.2 (TEST_TIMEOUT_SCALE=20)	07 Jul 2016 08:52PM UTC	86.35	Travis Job 2228.2
3	2228.3 (TEST_TIMEOUT_SCALE=20)	07 Jul 2016 08:55PM UTC	87.23	Travis Job 2228.3
4	2228.4 (TEST_TIMEOUT_SCALE=20)	07 Jul 2016 08:53PM UTC	86.21	Travis Job 2228.4
5	2228.5 (TEST_TIMEOUT_SCALE=20)	07 Jul 2016 08:56PM UTC	85.71	Travis Job 2228.5

Source Files on build 2228

Detailed source file information is not available for this build.

uber / tchannel-go / 2228
88%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 2228

uber / tchannel-go / 2228 88%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 2228

uber / tchannel-go / 2228
88%

README BADGES
x