Qiskit / qiskit / 10307373210

88%

Build Type

push

github

Committed by web-flow

Commit Message

Directly construct CircuitData in TwoQubitWeylDecomposition (#12809)

* Directly construct CircuitData in TwoQubitWeylDecomposition

In the recently merged #12740 a path was added for constructing the
`CircuitData` in rust when synthesizing to a `QuantumCircuit`
directly. However, in that PR this was done through a layer of
indirection by first collecting the gates into an intermediate `Vec`
and then passing an iterator of that into
`CircuitData::from_standard_gates()`. However this resulted in an
unecessary allocation for two `Vec`s and it would have been better
to just directly construct the `CircuitData` object directly. However,
to accomplish this we needed more rust space methods for creating
and manipulating a `CircuitData` object as it's mostly being constructed
from Python space or using `CircuitData::from_standard_gates()` with
an iterator so far. This commit makes those additions and then updates
the `TwoQubitWeylDecomposition` code to directly construct the
`CircuitData` object instead of using an intermediate `Vec`.

* Use set_global_phase instead of direct assignment

* Use slice inputs for push_standard_gate() params and qargs

Run Details

95 of 99 new or added lines in 2 files covered. (95.96%)

5 existing lines in 2 files now uncovered.

67375 of 75070 relevant lines covered (89.75%)

384439.97 hits per line