celerity / celerity-runtime / 10301951867

95%

master: 95%

Pull #273

github

Fix executor-scheduler race between instruction retirement and pruning

live_executor previously dereferenced instruction pointers on retirement,
which raced with their deletion on IDAG pruning when the executing
instruction was an horizon or epoch. To avoid future similar issues,
we now strictly regard the pointer to any instruction that has been issued
as dangling and work with instruction ids instead in those cases.

out_of_order_engine also had potentially hazardous uses of instruction
pointers that might - under the right circumstances - incorrectly regard
two instruction as identical when their pointers happen to alias as the
old one being freed before the new one was allocated in the same memory
location.

2980 of 3378 branches covered (88.22%)

Branch coverage included in aggregate %.

22 of 23 new or added lines in 2 files covered. (95.65%)

6547 of 6660 relevant lines covered (98.3%)

1533974.37 hits per line