zooniverse / front-end-monorepo / 10290504460

77%

push

github

fix(lib-react-components): AnimatedNumber displays async values as 0 (#6192)

* add an AnimatedNumber story for deferred animations

* add tests

* fix(lib-react-components): missing effect dependencies in AnimatedNumber

Refactor `AnimatedNumber` to add missing `value` and `duration` effect dependencies. Declare `animateValue` and `lessAnimation` callbacks inside the `useEffect` hook.

update initialValue when the animation completes

wait for async values to load before animating

* Refactor and document the d3 animation functions

* update the changelog

* replace if with ternary (no side effects!)

* announce stats changes as a status live region

* Simplify and clean up animation functions

* Wait for any pending animations to complete

* refactor intersectionCallback for readability

---------

Co-authored-by: Mark Bouslog <mcbouslog@gmail.com>

11683 of 16983 branches covered (68.79%)

Branch coverage included in aggregate %.

30 of 30 new or added lines in 2 files covered. (100.0%)

17118 of 19447 relevant lines covered (88.02%)

415.95 hits per line