fwupd / fwupd / 10272872587

53%

Build Type

push

github

Committed by hughsie

Commit Message

Add HWID-specific quirk-only GUIDs to I2C devices

These usually have very unhelpful names, e.g. `AUX A DDC` -- and MST plugins
are doing various crazy and fragile things to match the correct one.

Lets help by providing the HwId as part of the matched instance ID, e.g.

    FuEngine             /sys/devices/pci0000:00/0000:00:02.0/drm/card1/card1-DP-1/i2c-5 added FuI2cDevice:
      Flags:                none
      Guid[quirk]:          8a8c2f6d-6256-5d5f-9d20-6b5263af613d <- I2C\NAME_AUX-B-DDI-B-PHY-B
      Guid[quirk]:          c03110b9-e7ce-5b41-9bea-775f6f3f531c <- I2C\NAME_AUX-B-DDI-B-PHY-B&HWID_4ba7930e-afa6-547a-9155-e6d02898db42
      ...
      BackendId:            /sys/devices/pci0000:00/0000:00:02.0/drm/card1/card1-DP-1/i2c-5
      Number:               0x5
      Subsystem:            i2c
      DeviceFile:           /dev/i2c-5
    FuEngine             removing /sys/devices/pci0000:00/0000:00:02.0/drm/card1/card1-DP-1/i2c-5 from backend cache as no possible plugin

This is better than using FWUPD_PLUGIN_FLAG_REQUIRE_HWID as it allows us to
set device-specific quirk data from the device match, for instance:

    [I2C\NAME_AUX-B-DDI-B-PHY-B&HWID_4ba7930e-afa6-547a-9155-e6d02898db42]
    Plugin = parade_lspcon
    Name = PS175

Run Details

18390 of 33879 branches covered (54.28%)

Branch coverage included in aggregate %.

0 of 5 new or added lines in 1 file covered. (0.0%)

10 existing lines in 1 file now uncovered.

55139 of 117943 relevant lines covered (46.75%)

22365.87 hits per line