rust-bitcoin / rust-bitcoin / 10272584299

83%

push

github

Merge rust-bitcoin/rust-bitcoin#3129: hashes:: Rename const_hash functions

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/e7762e0612ce38cb2f934ccf91822003a71de096">e7762e061 hashes:: Rename const_hash functions (Tobin C. Harding)

Pull request description:

  There are a number of issues with the two `const_hash` functions in the `sha256` module:

  - The two `const_hash` functions in the `sha256` module differ slightly, one finalizes the hash and one is for computing the midstate.
  - They are inefficient and provided for usage for const context only.

  Fix both issues by renaming the functions as discussed in #3075.

  Close: #3075

ACKs for top commit:
  Kixunil:
    ACK e7762e0612ce38cb2f934ccf91822003a71de096
  apoelstra:
    ACK e7762e0612ce38cb2f934ccf91822003a71de096 successfully ran local tests

Tree-SHA512: 2b765bbba30de489cfce10a1ff16e5568f9

9 of 10 new or added lines in 1 file covered. (90.0%)

19700 of 23673 relevant lines covered (83.22%)

15637.79 hits per line