rust-bitcoin / rust-bitcoin / 10269429288

83%

push

github

Merge rust-bitcoin/rust-bitcoin#3077: hashes: Add a new `hash_reader` function

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/0a045d87ea267ee8495c2b6e9faa92d1ee05540f">0a045d87e hashes: Add a new hash_reader function (Tobin C. Harding)

Pull request description:

  Add a function `hash_reader` that uses the `BufRead` trait to read bytes directly into the hash engine.

  Add the functionality to:

  - as a trait method in the `GeneralHash` trait with default implementation
  - as inherent functions to all the hash types

  Close: #3050

ACKs for top commit:
  Kixunil:
    ACK 0a045d87ea267ee8495c2b6e9faa92d1ee05540f
  apoelstra:
    ACK 0a045d87ea267ee8495c2b6e9faa92d1ee05540f successfully ran local tests

Tree-SHA512: 225f1d72fe9c8712c5a7a87fa8245d0db8c

25 of 40 new or added lines in 3 files covered. (62.5%)

19708 of 23692 relevant lines covered (83.18%)

15589.08 hits per line