Gallopsled / pwntools / 10247624375

74%

Build Type

push

github

Committed by web-flow

Commit Message

gdb.debug: avoid 2s timeout if possible (#2435)

On Ubuntu 22.04 gdb.debug() takes at least 2 seconds. This is because
it prints only "Remote debugging from host 127.0.0.1, port 33398", but
the code expects 2 lines.

It's very unclear what the second line is supposed to be; the only lead
is "* Handle extra newline printed by gdb" in commit 338fbeba ("Improve
pwnup template, gdbserver detection (#1148)"), but I could not trace it
back to the GDB source code, both historic and modern. Perhaps, there
is a non-upstreamed patch in some distro that introduces it.

It should still be safe to skip waiting for the second line if the
first one already starts with "Remote debugging ...", so do it.

Run Details

4498 of 7318 branches covered (61.46%)

4 of 6 new or added lines in 1 file covered. (66.67%)

4 existing lines in 2 files now uncovered.

13107 of 17735 relevant lines covered (73.9%)

0.74 hits per line