• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

supabase / auth / 10247113177
69%

Build:
DEFAULT BRANCH: master
Ran 05 Aug 2024 10:32AM UTC
Jobs 1
Files 127
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

05 Aug 2024 10:27AM UTC coverage: 58.368% (+0.04%) from 58.333%
10247113177

push

github

web-flow
fix: enforce uniqueness on verified phone numbers (#1693)

## What kind of change does this PR introduce?

With this change:
- Multiple verified phone mfa factors can exist so long as they have
distinct phone numbers (see discussion below)
- Enrolling a factor with a number that is the same as the existing
verified factor will result in a 422 status code
- Enrolling a factor with a number that is the same as another existing
unverified factor will result in the deletion of the older factor.

Also includes:
- A refactor to check for duplicate constraints at application level
then at the Postgres layer.
- A narrowing of deletion so that only unverified factors of the same
type are deleted upon first successful verification

Follow up to #1687 to support the unique constraint on phone factors.

26 of 36 new or added lines in 2 files covered. (72.22%)

9200 of 15762 relevant lines covered (58.37%)

55.23 hits per line

New Missed Lines in Diff

Lines Coverage ∆ File
10
64.44
0.36% internal/api/mfa.go
Jobs
ID Job ID Ran Files Coverage
1 10247113177.1 05 Aug 2024 10:32AM UTC 127
58.37
GitHub Action Run
Source Files on build 10247113177
  • Tree
  • List 127
  • Changed 35
  • Source Changed 0
  • Coverage Changed 2
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • 70446cc1 on github
  • Prev Build on master (#10238217910)
  • Next Build on master (#10247443598)
  • Delete
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2025 Coveralls, Inc