openconfig / ygot / 10240366149

89%

push

github

🐜: squash bug related to leaf-lists and shadow schemas. (#980)

* 🐜: squash bug related to leaf-lists and shadow schemas.

 * (M) util/reflect.go
   - Fix missing parameter to string output.
 * (M) ytypes/{leaf,node,node_test,schema_test,util_schema}.go
   - Two bugs fixed.
     1. In the case that one calls `SetNode` with something that was
        not a gNMI `TypedValue` and was not JSON, then we could panic
        when attempting to type cast it.
     2. If a schema was generated that uses path compression, and
        `SetNode` was called for a node that was compressed out, but
        `PreferShadowPaths` was not set AND this node was a leaf-list
        then rather than performing a no-op (the expected behaviour,
        since we asked to set a node that was not the 'preferred' thing
        to set), then we would bail with an error since the schema was
        not a leaf schema. Small fix, lots of testing to find the root
        cause here.
 * (M) ytypes/schema_test/set_test.go
   - Bug reproduction.

* Remove `TestFish`. 🐠

11 of 12 new or added lines in 3 files covered. (91.67%)

13916 of 15670 relevant lines covered (88.81%)

482.64 hits per line