• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

Qiskit / qiskit / 10217580379
88%

Build:
DEFAULT BRANCH: main
Ran 02 Aug 2024 03:15PM UTC
Jobs 1
Files 859
Run time 2min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

02 Aug 2024 02:00PM UTC coverage: 89.735% (-0.007%) from 89.742%
10217580379

push

github

web-flow
Avoid exporting incorrect `PyInit_*` symbols (#12889)

Using the `#[pymodule]` derive macro in PyO3 0.21 always causes a
`PyInit_*` symbol with a matching name to be exported in the output
`cdylib`.  This is required for the top-level module, in order for
Python to import it---it needs to know which symbol in a shared library
file it should call---but submodules must be manually initialised, so do
not need it.  Including it is typically harmless (and something we've
been doing for a long time), but it is technically against the coding
rules for CPython extensions[^1].

Recent versions of `abi3audit` (0.0.11+) have tightened their symbol
checkers to better match the CPython guidelines, which causes our wheels
to be rejected by their audits.  This is, in theory, not a break of abi3
because CPython could never introduce an API-elvel `PyInit_*` function
themselves without causing problems, so there ought to be no problems
for our users, even with future Python versions. That said, we still
want to pass the audit, because the coding guidelines are useful.

This commit is not the cleanest way of doing things.  PyO3 0.22 includes
a `#[pymodule(submodule)]` option on the attribute macro, which lets us
use all the standard code generation while suppressing the unnecessary
`PyInit_*` symbol.  When we are ready to move to PyO3 0.22, we probably
want to revert this commit to switch to that form.

[^1]: https://docs.python.org/3/c-api/intro.html

42 of 42 new or added lines in 4 files covered. (100.0%)

7 existing lines in 2 files now uncovered.

67333 of 75035 relevant lines covered (89.74%)

388938.01 hits per line

Jobs
ID Job ID Ran Files Coverage
1 10217580379.1 02 Aug 2024 03:15PM UTC 0
89.74
GitHub Action Run
Source Files on build 10217580379
Detailed source file information is not available for this build.
  • Back to Repo
  • 120b73d2 on github
  • Prev Build on gh-readonly-queue/main/pr-12887-6663db17a1b87e3101368002f592d37a369048a4 (#10216685189)
  • Next Build on main (#10220517788)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc