gnachman / iTerm2 / 463

30%

push

travis-ci

Fix a crash where some preference panel view controllers remained allocated after the pref panel was released. There were cyclic references in various blocks. The fix for most of them is to remove the blocks in PreferenceInfo when the window closes. A color well block also had a cycle, and I fixed it by using an unsafe unretained pointer. Blocks are non-arc code are scary.

18 of 18 new or added lines in 3 files covered. (100.0%)

27569 of 92444 relevant lines covered (29.82%)

31.36 hits per line