10188161155
96%

Ran 31 Jul 2024 09:50PM UTC

Jobs 1

Files 11

Run time 1min

Badge

Embed ▾

Committed 31 Jul 2024 09:42PM UTC coverage: 86.139% (+1.2%) from 84.901%

Build # 10188161155

Build Type

push

github

Committed by

safl

Commit Message

Refactor(errors): Wrap Errors in TableError(BaseModel)

Refactored error types to have a common parent error type (`TableError`)
to address the mypy error on Windows. Initially, NamedTuple classes
were considered, but they undermined inheritance benefits and introduced
additional issues. Therefore, `pydantic.BaseModel` was used for the
following advantages:

- Provides serialization, eliminating the need for `error_to_dict()`.
- Enforces the use of named arguments, reducing potential errors when refactoring argument order.
- Fixes the mypy issue with missing type information.

src\senfd\errors.py:17: error: Invalid type alias: expression is not a valid type  [valid-type]
src\senfd\errors.py:17: error: Unsupported left operand type for | ("type[TableOfFiguresError]")  [operator]
src\senfd\errors.py:25: error: Variable "senfd.errors.TableError" is not valid as a type  [valid-type]
src\senfd\errors.py:25: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
src\senfd\errors.py:26: error: TableError? has no attribute "_asdict"  [attr-defined]
Found 4 errors in 1 file (checked 18 source files)

Signed-off-by: Simon A. F. Lund <os@safl.dk>

Run Details

348 of 404 relevant lines covered (86.14%)

0.86 hits per line

Uncovered Existing Lines

Lines	Coverage	∆	File
3	87.21	0.0%	opt/pipx/venvs/senfd/lib/python3.10/site-packages/senfd/documents/plain.py
5	58.06	0.0%	opt/pipx/venvs/senfd/lib/python3.10/site-packages/senfd/tables.py

Jobs

ID	Job ID	Ran	Files	Coverage
1	10188161155.1	31 Jul 2024 09:50PM UTC	11	86.14	GitHub Action Run

safl / senfd / 10188161155
96%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 10188161155

safl / senfd / 10188161155 96%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 10188161155

safl / senfd / 10188161155
96%

README BADGES
x