#19384

Committed 31 Jul 2024 09:16PM UTC coverage: 84.47% (+0.02%) from 84.448%

Build # #19384

Build Type

push

github

Committed by

ejona86

Commit Message

Revert "Introduce onResult2 in NameResolver Listener2 that returns Status (#11313)"

This reverts commit 9ba2f9dec.

It causes a channel panic due to unimplemented onResult2().

```
java.lang.UnsupportedOperationException: Not implemented.
        at io.grpc.NameResolver$Listener2.onResult2(NameResolver.java:257)
        at io.grpc.internal.DnsNameResolver$Resolve.lambda$run$0(DnsNameResolver.java:334)
        at io.grpc.SynchronizationContext.drain(SynchronizationContext.java:94)
        at io.grpc.SynchronizationContext.execute(SynchronizationContext.java:126)
	at io.grpc.internal.DnsNameResolver$Resolve.run(DnsNameResolver.java:333)
```

b/356669977

Run Details

33267 of 39383 relevant lines covered (84.47%)

0.84 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

0.0

/../netty/src/main/java/io/grpc/netty/InsecureFromHttp1ChannelCredentials.java

/*
 * Copyright 2020 The gRPC Authors
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 *     http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */

package io.grpc.netty;

import io.grpc.ChannelCredentials;
import io.grpc.ExperimentalApi;

/** An insecure credential that upgrades from HTTP/1 to HTTP/2. */
@ExperimentalApi("There is no plan to make this API stable, given transport API instability")
public final class InsecureFromHttp1ChannelCredentials {
  private InsecureFromHttp1ChannelCredentials() {}

  /** Creates an insecure credential that will upgrade from HTTP/1 to HTTP/2. */
  public static ChannelCredentials create() {
    return NettyChannelCredentials.create(ProtocolNegotiators.plaintextUpgradeClientFactory());
  }
}

1	/*
2	* Copyright 2020 The gRPC Authors
3	*
4	* Licensed under the Apache License, Version 2.0 (the "License");
5	* you may not use this file except in compliance with the License.
6	* You may obtain a copy of the License at
7	*
8	* http://www.apache.org/licenses/LICENSE-2.0
9	*
10	* Unless required by applicable law or agreed to in writing, software
11	* distributed under the License is distributed on an "AS IS" BASIS,
12	* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13	* See the License for the specific language governing permissions and
14	* limitations under the License.
15	*/
16
17	package io.grpc.netty;
18
19	import io.grpc.ChannelCredentials;
20	import io.grpc.ExperimentalApi;
21
22	/** An insecure credential that upgrades from HTTP/1 to HTTP/2. */
23	@ExperimentalApi("There is no plan to make this API stable, given transport API instability")
24	public final class InsecureFromHttp1ChannelCredentials {
25	private InsecureFromHttp1ChannelCredentials() {}
26
27	/** Creates an insecure credential that will upgrade from HTTP/1 to HTTP/2. */
28	public static ChannelCredentials create() {
29	return NettyChannelCredentials.create(ProtocolNegotiators.plaintextUpgradeClientFactory());	×
30	}
31	}

grpc / grpc-java / #19384

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous