supabase / auth / 10180835942

69%

push

github

fix: MFA NewFactor to default to creating unverfied factors (#1692)

## What kind of change does this PR introduce?

- Split `NewFactor` into `NewPhoneFactor()` and `NewTOTPFactor()`. 
- All `New<Type>Factor` methods will now create unverified factors.
- Additionally, also guards the `Challenge` endpoint when verification
is disabled for a factor.


The hope is to reduce cognitive load and the chance of creating a factor
in an undesired state


Should one wish to obtain a Verified Factor (say for tests) they can
call `UpdateStatus`. It is unlikely for this to be a common use case
though.

Someone might have brought this up prior but only getting to it now

14 of 20 new or added lines in 2 files covered. (70.0%)

9163 of 15744 relevant lines covered (58.2%)

54.65 hits per line