• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

Open-MSS / MSS / 10175102977
70%
develop: 70%

Build:
Build:
LAST BUILD BRANCH: another_i2958
DEFAULT BRANCH: develop
Ran 31 Jul 2024 06:25AM UTC
Jobs 1
Files 105
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

31 Jul 2024 06:17AM UTC coverage: 69.695% (-0.2%) from 69.895%
10175102977

push

github

web-flow
Fix inconsistent SocketsManager objects (#2444)

On import of mslib.mscolab.server initialize_managers was called once,
hooking events up to handlers in a SocketsManager instance and
initializing the Flask app with the Flask-SocketIO extension. Then, in
handle_start, initialize_managers was called a second time, creating
another SocketsManager object, overwriting the instance saved with the
SocketIO object, and trying to initialize the Flask app with it again.

The last step does not work though, a Flask app can only be initialized
once with each extension (i.e. the sockio.init_app(app) call can only be
done once per Flask app object).

What this led to is that the Flask-SocketIO extension was using the
first SocketsManager object to handle incoming events, while the server
side was using the second SocketsManager object when it called methods
on sockio.sm.

This changes the startup process to do the initialization just once.

5 of 7 new or added lines in 3 files covered. (71.43%)

40 existing lines in 1 file now uncovered.

13679 of 19627 relevant lines covered (69.69%)

0.7 hits per line

Jobs
ID Job ID Ran Files Coverage
1 10175102977.1 31 Jul 2024 06:25AM UTC 0
69.69
GitHub Action Run
Source Files on build 10175102977
Detailed source file information is not available for this build.
  • Back to Repo
  • b4118a46 on github
  • Prev Build on stable (#9792278148)
  • Next Build on stable (#10193055548)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc