expressjs / body-parser / 10170191785

99%

master: 99%

Build Type

Pull #66

github

Committed by web-flow

Commit Message

urlencoded: Support iso-8859-1, utf8 sentinel, and numeric entities (#326)

* urlencoded, in extended mode: Support iso-8859-1 encoded requests, and also accept iso-8859-1 as a default encoding.

* urlencoded: Support an utf8 sentinel to detect the charset.

* Pass the interpretNumericEntities option through to qs.

* Fix lint

* Support charsets, sentinels etc. via custom decoders

Works in both extended and simple mode.

* Simplify

* Fix empty parameter issue with utf8Sentinel in simple mode

* Run all the charset/sentinel tests in both extended and simple modes

* utf8Sentinel => charsetSentinel

https://github.com/ljharb/qs/pull/268#discussion_r207115487

* Update qs to 6.9.1

* Always use the qs module, even in simple mode

https://github.com/expressjs/body-parser/pull/326#issuecomment-521823039

* Create the simple and extended parser with the same function, reducing duplication

* Don't mention the querystring module in the README

* Fix lint

* Update qs to 6.9.4

* Consistently call it "utf8 sentinel"

* Simplify by relying on the qs module's support for detecting the charset
https://github.com/expressjs/body-parser/pull/326#discussion_r1693684912

* Simplify further

* Put back debug option

* Document that defaultCharset defaults to utf-8
https://github.com/expressjs/body-parser/pull/326#discussion_r1693684214

Pull Request Pull Request #66: Release 2.0

Run Details

35 of 36 new or added lines in 6 files covered. (97.22%)

1 existing line in 1 file now uncovered.

318 of 320 relevant lines covered (99.38%)

972.62 hits per line