Qiskit / qiskit / 10167409225

90%

main: 88%

Build Type

push

github

Committed by web-flow

Commit Message

Recreate full dag instead of inplace substitution in BasisTranslator (#12195) (#12855)

* Recreate full dag instead of inplace substitution in BasisTranslator

This commit tweaks the internal logic of the basis translator transpiler
pass to do a full dag recreation instead of inplace modification. If
only a few operations were to be substituted it would probably be more
efficient to do an inplace modification, but in general the basis
translator ends up replacing far more operations than not. In such cases
just iterating over the dag and rebuilding it is more efficient because
the overhead of `apply_operation_back()` is minimal compared to
`substitute_node_with_dag()` (although it's higher than
`subtitute_node(.., inplace=True)`).

* Return boolean together with dag in 'apply_translation' to maintain original 'flow_blocks' logic and fix drawer test.

* Remove print

---------

Co-authored-by: Elena Peña Tapia <epenatap@gmail.com>
(cherry picked from commit 37b334fb7)

Co-authored-by: Matthew Treinish <mtreinish@kortar.org>

Run Details

32 of 32 new or added lines in 1 file covered. (100.0%)

2 existing lines in 1 file now uncovered.

66372 of 73760 relevant lines covered (89.98%)

227659.53 hits per line