RDFLib / rdflib / 10154699676

90%

master: 91%

Build Type

push

github

Committed by web-flow

Commit Message

Prevent Collection from adding 'rdf:nil rdf:rest rdf:nil.' triples (#2818)

* fix: Prevent Collection from add 'rdf:nil rdf:rest rdf:nil.' triples

Creating 'Collection(graph, RDF.nil)' used to add a 'rdf:nil rdf:rest rdf:nil.'
triple to the graph, which turned the empty list into an infinite list.

This was a side-effect of unconditionally appending 'seq' to the collection,
which is not possible when the collection is 'nil' without ill side-effects.

This commit makes the append conditional; and also checks the collection
is non-empty in case the user explicitly tries to add item to the empty list.

* Move emptiness check out of _end()

This will allow using _end() in other methods that would not need to append

* Also prevent insertion at the end of finalized lists

Co-authored-by: Ashley Sommer <ashleysommer@gmail.com>

* Also prevent .append() on finalized lists

Co-authored-by: Ashley Sommer <ashleysommer@gmail.com>

---------

Co-authored-by: Nicholas Car <nick@kurrawong.net>
Co-authored-by: Ashley Sommer <ashleysommer@gmail.com>

Run Details

6137 of 7671 branches covered (80.0%)

4 of 6 new or added lines in 1 file covered. (66.67%)

2 existing lines in 1 file now uncovered.

19383 of 21388 relevant lines covered (90.63%)

11.48 hits per line