769
86%

Ran 17 Apr 2014 09:37AM UTC

Jobs 2

Files 22

Run time 1min

Badge

Embed ▾

pending completion

Build # 769

Build Type

Pull #360

travis-ci

Committed by

benjie

Commit Message

Prevent rendering race conditions with slow APIs.

You have three pages: A, B and C; where B takes 2 seconds to load it's data from the API and the other two are relatively instant. You start at A, click B then click C (without waiting for B to load). The previous result is that you see A's content, then C's content, then finally B's content. But the address bar shows C's URL, since URLs update immediately independent of page load time. C's URL with B's content?! ARGH.

This change is a simple fix for this by counting requests - if you've initiated a new page load before the old one completes then the old one will never render.

WARNING: this does not work around issues such as triggering `action:end` for the old request or anything like that.

Pull Request Pull Request #360: Prevent rendering race conditions with slow APIs.

Run Details

965 of 1250 relevant lines covered (77.2%)

21.94 hits per line

Uncovered Existing Lines

Lines	Coverage	∆	File
7	90.0	-5.83%	/home/travis/build/rendrjs/rendr/shared/base/router.js

Jobs

ID	Job ID	Ran	Files	Coverage
1	769.1	17 Apr 2014 09:37AM UTC	22	77.2	Travis Job 769.1
2	769.2	17 Apr 2014 09:38AM UTC	22	77.2	Travis Job 769.2

Source Files on build 769

Coverage	∆	File	Lines	Relevant	Covered	Missed	Hits/Line

rendrjs / rendr / 769
86%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 769

rendrjs / rendr / 769 86%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 769

rendrjs / rendr / 769
86%

README BADGES
x