lucyparsons / OpenOversight / 10148377947
89%

DEFAULT BRANCH: develop
Ran
Jobs 1
Files 96
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 88.938%. Remained the same
10148377947

push

github

web-flow 
Remove `transaction.rollback()` and use `session` fixture (#1117)

## Fixes issue
https://github.com/lucyparsons/OpenOversight/issues/1054
- This is the last PR for this issue. ❗❗❗❗❗❗ 

## Description of Changes
Removed the redundant `transaction.rollback()` function call in the
`session` fixture and changed all references to `db.session` to
`session` so that tests are using the correct scoping.

Addressed this warning:
```console
=============================================================================================== warnings summary ===============================================================================================
OpenOversight/tests/test_commands.py::test_add_department__duplicate
OpenOversight/tests/test_models.py::test__uuid_uniqueness_constraint
OpenOversight/tests/routes/test_singular_redirects.py::test_redirect_add_salary
  /usr/src/app/OpenOversight/tests/conftest.py:325: SAWarning: transaction already deassociated from connection
    transaction.rollback()

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html

---------- coverage: platform linux, python 3.11.9-final-0 -----------
```

## Tests and Linting
- [x] This branch is up-to-date with the `develop` branch.
- [x] `pytest` passes on my local development environment.
- [x] `pre-commit` passes on my local development environment.
- [x] Validate that no more warnings show up in the `make test` command.

```console
---------- coverage: platform linux, python 3.11.9-final-0 -----------
Name                                                                                                         Stmts   Miss  Cover
--------------------------------------------------------------------------------------------------------------------------------
OpenOversight/__init__.py                                                                                        0      0   100%
OpenOversight/app/__init__.py                          ... (continued)

8530 of 9591 relevant lines covered (88.94%)

0.89 hits per line

Jobs
ID Job ID Ran Files Coverage
1 10148377947.1 0
88.94
 GitHub Action Run
Source Files on build 10148377947
Detailed source file information is not available for this build.