OpenRefine / OpenRefine / 10142705844

50%

push

github

Preserve pagination after actions which trigger a grid update (#6546)

* Preserve pagination after actions which trigger an update of the grid (#5411)

* Adapt the GridState interface to separate sorting and pagination.

This adds `getRowsBefore` methods, counterpart to the existing pagination
methods, so that we can do efficient and correct pagination, solving #33 and #570

* Revert "(I #2638) Feature to Goto a page directly (#2639)"

Go back to simply displaying a range of row numbers, because
that will enable a solution for #33, #570 and #572.
This reverts commit d7aaac2e9.

* Do not move back to the first page when applying an action which refreshes the grid.

Instead, the current page is refreshed.
This closes #33, closes #570, closes #572.

* Specify which actions preserve row and record ids

This lets us preserve pagination only when it is guaranteed to show the same
part of the data after the operation.

* Make paging user-editable like before

* Adapt cypress tests

* Preserve pagination also when discarding recon matches

* Small changes from review feedback

Co-authored-by: Tom Morris <tfmorris@gmail.com>

6752 of 12269 branches covered (55.03%)

Branch coverage included in aggregate %.

17144 of 25824 relevant lines covered (66.39%)

2.99 hits per line