sapcc / limes / 10141794878

80%

push

github

Add GET commitment by token endpoint with proper UNIQUE key (#508)

* Add GET commitment by token endpoint

* Add documentation

* Fix lint

* Update docs/users/api-spec-resources.md

Co-authored-by: Stefan Majewsky <stefan.majewsky@sap.com>

* Remove audit log
shorten endpoint to v1/commitments/:token

* Update internal/api/commitment.go

Co-authored-by: Stefan Majewsky <stefan.majewsky@sap.com>

* Update internal/api/commitment.go

Co-authored-by: Stefan Majewsky <stefan.majewsky@sap.com>

* Add unique key to transfer_token
remove code to check for a duplicate token

* add down migration for 044, use same naming style as for existing constraints

* Add partial index to transfer_token column

* fix letter casing on migration

* Remove leftover migration from last conflict cleanup

* Remove unreachable error checks
Add down migration

* Add proper down migration statement

* Add logic to add proper unique column

* Fix: capacity scrape tests
Issue was that the DB snapshot diff read all keys from a row and inserted it into the result set

* multiple review nitpicks

- `project:show` is not a valid permission level for
  GetCommitmentByTransferToken, because it depends on `domain_id` and
  `project_id` parameters in the URL which this endpoint does not have.
  The closest to a "any valid user" permission level that we have is
  `cluster:show_basic`, so I'm going with this for now. The v2 API will
  probably see a policy restructuring, so I will let this stand for now.

- The migration is adjusted to use the default naming for the index, for
  consistency with the existing schema.

- In the down migration, a default value needs to be added first because
  NON NULL columns must have a default value expression.

---------

Co-authored-by: Stefan Majewsky <stefan.majewsky@sap.com>

24 of 33 new or added lines in 2 files covered. (72.73%)

4524 of 5719 relevant lines covered (79.1%)

45.68 hits per line