rust-bitcoin / rust-bitcoin / 10133622360

83%

Build Type

push

github

Committed by apoelstra

Commit Message

Merge rust-bitcoin/rust-bitcoin#3003: ci: semver-checks for non-additive cargo features

f76f68217 ci: pin cargo-semver-checks version and cron job (Jose Storopoli)
8a9101576 ci: harden zip command with -n (Jose Storopoli)
4edd504cb ci: pin stable in semver-checks and updates weekly (Jose Storopoli)
194899544 ci: semver-check for non-additive cargo features (Jose Storopoli)
b5180732e io: add not_unwind_safe as PhantomData (Jose Storopoli)

Pull request description:

  Closes #3001.
  Closes #3023.

  ## Summary

  Adds new CI Job that checks for semver breaks in `no-default-features` against `all-features`.
  A fail would represent that we are inserting non-additive cargo features.

  Credits to @Kixunil for the amazing idea.

  This PR does:

  1. fix a non-additive feature in `bitcoin-io`;
  1. move the current `semver-checks` to `semver-checks-pr` since it checks if the PR is introducing classical semver-checks;
  1. adds a new `semver-checks-feature`;
  1. Add `-n` to `unzip` in `semver-checks`;
  1. pins `rustc` stable and updates in a cron job weekly on Fri; and
  1. pins `cargo-semver-checks` to `0.33.0` and updates in a cron job weekly on Sat.

  ## Implementation notes

  We don't need nightly (and somehow it fails) but if we incorporate the ENV [`RUSTC_BOOTSTRAP=1` as hardcoded in the cargo-semver-checks codebase](https://github.com/obi1kenobi/cargo-semver-checks/blob/50b93599d/src/rustdoc_cmd.rs#L110C17-L110C39) and run `cargo` with the stable toolchain it works.

  To get the `cargo-semver-checks` version we use the [`crates.io` API](https://crates.io/api/v1/crates/cargo-semver-checks) along with some quite intelligible `jg` magic (NOTE: `jq` is available in GH's `ubuntu-latest` image).

ACKs for top commit:
  Kixunil:
    ACK f76f68217b3f29cdfe3ed012091e07... (continued)

Coverage Stats

2 of 7 new or added lines in 1 file covered. (28.57%)

1 existing line in 1 file now uncovered.

19671 of 23643 relevant lines covered (83.2%)

15578.71 hits per line