10122702951
78%
master: 79%

Ran 27 Jul 2024 10:07AM UTC

Jobs 3

Files 260

Run time 1min

Badge

Embed ▾

Committed 27 Jul 2024 10:03AM UTC coverage: 74.597%. Remained the same

Build # 10122702951

Build Type

push

github

Committed by

jrfnl

Commit Message

Tests/ConfigDouble: bug fix - always reset Config statics after use

The `Config` class uses a number of static properties, which may be updated during tests. These were previously - prior to 275 - reset to their default values in the `AbstractMethodUnitTest::resetTestFile()` method, but this reset was inadvertently removed with the reasoning that, if all tests use the `ConfigDouble`, the reset would no longer be needed as the `ConfigDouble` resets on being initialized.

The flaw in this logic is that not all tests are guaranteed to use the `ConfigDouble`, which means that without the reset, the `Config` class may be left "dirty" after tests using the `ConfigDouble`, which could break tests.

This commit fixes this issue by:
* Adding a `__destruct()` method to the `ConfigDouble` class which will reset the static properties on the PHPCS native `Config` class whenever an object created from this class is destroyed.
* Explicitly calling the `__destruct()` method from the `AbstractMethodUnitTest::reset()` method to ensure it is always run after a test has finished ("after class"), even if there would still be a lingering reference to the object.

This is only a stability tweak, there are no existing tests affected by this issue at this time.

Run Details

17969 of 24088 relevant lines covered (74.6%)

71.71 hits per line

Jobs

ID	Job ID	Ran	Coverage
1	php-8.1-custom-ini-true - 10122702951.1	27 Jul 2024 10:07AM UTC	72.36	GitHub Action Run
2	php-7.2-custom-ini-false - 10122702951.2	27 Jul 2024 10:09AM UTC	70.49	GitHub Action Run
3	php-8.3-custom-ini-false - 10122702951.3	27 Jul 2024 10:08AM UTC	72.33	GitHub Action Run

Source Files on build 10122702951

Detailed source file information is not available for this build.

PHPCSStandards / PHP_CodeSniffer / 10122702951
78%
master: 79%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 10122702951

PHPCSStandards / PHP_CodeSniffer / 10122702951 78% master: 79%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 10122702951

PHPCSStandards / PHP_CodeSniffer / 10122702951
78%
master: 79%

README BADGES
x