amazon-aurora / babelfish_extensions / 10088358112

74%

main: 77%

push

github

Added wrapper function for TRIM, LTRIM, RTRIM, LEFT and RIGHT (#2481)

Currently, for string functions TRIM, LTRIM, RTRIM, LEFT and RIGHT underlying Postgres function is being used which
leads to incorrect output behaviour. This commit will fix this issue by adding wrapper functions for these string
functions.

Changes included in this commit are as follows:-

1. Added wrapper functions for TRIM, LTRIM, RTRIM, LEFT and RIGHT.
2. Added hook func_select_candidate_for_special_hook for selecting best candidate among list of functions definitions
based on return type for string functions which are in special function list.
3. Updated definition of function pltsql_report_proc_not_found_error  to include input_typeids of function.
4. Added PG_CATALOG namespace before TRIM, LTRIM, RTRIM, LEFT or RIGHT function invocations in some of the
system functions as with these wrapper definitions of TRIM, LTRIM, RTRIM, LEFT and RIGHT functions in sys
namespace, any function invocation of TRIM, LTRIM, RTRIM, LEFT or RIGHT function without namespace, by default it
will call the function in sys namespace.
4. Added new test files and updated existing test files expected output as the output behaviour of these functions will
change with this fix.
5. In case of Inline Table Valued Function(ITVF), made changes such that if the return type of body is different than
return type stored for during creation of ITVF, an implicit cast will occur and return type of body will be casted to return
type stored.
6. fixed composite actions to avoid replacing partial word for test files present in schedule file of upgrades.

Engine PR: babelfish-for-postgresql/postgresql_modified_for_babelfish#342

Task: BABEL-4489
Signed-off-by: Rohit Bhagat <rohitbgt@amazon.com>

129 of 140 new or added lines in 5 files covered. (92.14%)

43039 of 58743 relevant lines covered (73.27%)

114602.34 hits per line