tarantool / tarantool / 10073314144

88%

Build Type

push

github

Committed by locker

Commit Message

vinyl: skip bad vylog records in force_recovery mode

We've had a number of issues when Tarantool was permanently broken
(unable to recover after restart) because of a bad vylog record.
The `force_recovery` mode didn't help so the user would have no other
choice but to rebootstrap. A funny thing is those bugs were usually
caused by a race between the garbage collector and dump/compaction when
a vylog record was written for a dropped index. The worst thing that
could happen if we ignored such a bad record is an unused run file not
deleted from disk. Apparently, this is better than a permanent recovery
failure so let's support the `force_recovery` mode in vylog.

The tricky part here is handling checkpoint after restart. The problem
is that to create a vylog checkpoint, we load the previous vylog file
so we have to ignore errors if it was loaded in the `force_recovery`
mode.

Closes #10292

NO_DOC=bug fix

Run Details

67893 of 120962 branches covered (56.13%)

31 of 33 new or added lines in 1 file covered. (93.94%)

199 existing lines in 13 files now uncovered.

100649 of 115477 relevant lines covered (87.16%)

2471709.39 hits per line