OCHA-DAP / hapi-pipelines / 10066386155

93%

Build Type

push

github

Committed by web-flow

Commit Message

HDXDSYS-898 Refactor org code (#134)

* Add uncleaned names as keys to lookups
Remove intersectoral check
dict() to {}
Move branches that have continue higher up in loops in operational presence

* Some rearrangement of operational presence and comments to help me understand the org processing

* Small reorg of org type if code

* store normalised keys as well as non normalised

* Use already normalised key

* Simplify org lookup code and operational presence

* Add to lookup to reduce need to keep normalising

* Pass around normalise variables

* Remove org lookup only used in test

* Remove unnecessary variable

* Update CHANGELOG

* Can just return value here

* Combine ifs

* Use named tuples for clarity

* Rename value to org_info

* Use org_data in populate_multiple

* Use OrgData in tests

* Make OrgInfo into a data class
Add used and complete bools to OrgInfo
Correct OrgInfo objects in org_map with corrections from looking up in data member variable

* Make separate function

* Add debug option to command line
Add org_map debug

Run Details

116 of 134 new or added lines in 7 files covered. (86.57%)

3 existing lines in 2 files now uncovered.

1387 of 1489 relevant lines covered (93.15%)

0.93 hits per line