c-ares / c-ares / #1297

81%

main: 92%

Build Type

push

travis-ci

Committed by bradh352

Commit Message

mem leak due to `ares__hosts_entry_to_hostent()` allocation strategy (#824)

`ares__hosts_entry_to_hostent()` would allocate a separate buffer for
each address, but `ares_free_hostent()` expects a single allocation to
hold all addresses.

This PR fixes this issue and simplifies the logic by using the
already-existing `ares__addrinfo2hostent()` to write the hostent instead
of coming up with yet another way to write the structure.

Fixes #823
Fix By: Brad House (@bradh352)

Coverage Stats

15 of 22 new or added lines in 1 file covered. (68.18%)

1 existing line in 1 file now uncovered.

8699 of 10769 relevant lines covered (80.78%)

3829.94 hits per line