c-ares / c-ares / 10047407198

92%

Build Type

push

github

Committed by web-flow

Commit Message

mem leak due to `ares__hosts_entry_to_hostent()` allocation strategy (#824)

`ares__hosts_entry_to_hostent()` would allocate a separate buffer for
each address, but `ares_free_hostent()` expects a single allocation to
hold all addresses.

This PR fixes this issue and simplifies the logic by using the
already-existing `ares__addrinfo2hostent()` to write the hostent instead
of coming up with yet another way to write the structure.

Fixes #823 
Fix By: Brad House (@bradh352)

Run Details

15 of 20 new or added lines in 1 file covered. (75.0%)

2 existing lines in 2 files now uncovered.

19249 of 21021 relevant lines covered (91.57%)

7120.62 hits per line