JaCraig / Archivist / 10017337279

78%

Build Type

push

github

Committed by JaCraig

Commit Message

fix: Finishing XML format changes

This commit represents a major overhaul in the project's serialization and deserialization approach, transitioning from `System.Text.Json` to `Newtonsoft.Json` due to limitations with dynamic objects. Key changes include:

- Updated multiple files across the project, including test and format-specific classes, to use `Newtonsoft.Json` for JSON and XML handling.
- Modified serialization options in test classes (`JsonFormatTests.cs`, `JsonReaderTests.cs`, `JsonWriterTests.cs`, `XMLFormatTests.cs`, `XMLReaderTests.cs`) from `JsonSerializerOptions` to `JsonSerializerSettings`.
- Updated namespace and class references in test classes to avoid ambiguity.
- Added new test cases in `XMLFormatTests.cs` and `XMLReaderTests.cs` for enhanced coverage.
- Revised `StructuredObject.cs` methods for string conversion and content retrieval to utilize `Newtonsoft.Json` methods.
- Introduced a `ToByteArray` extension method in `InternalExtensionMethods.cs` for efficient string to byte array conversion.
- Overhauled core format classes (`JsonFormat.cs`, `JsonReader.cs`, `JsonWriter.cs`, `XMLFormat.cs`, `XMLReader.cs`, `XMLWriter.cs`) to adopt `Newtonsoft.Json` for all serialization and deserialization tasks.
- Added a `CleanUpReturnValue` method in `XMLReader.cs` for cleaner deserialized data.
- Updated `XMLWriter.cs` to convert structured objects to XML strings using an approach involving `Newtonsoft.Json`.

These changes leverage `Newtonsoft.Json`'s flexibility and features for improved JSON and XML processing capabilities.

Coverage Stats

1187 of 1494 branches covered (79.45%)

Branch coverage included in aggregate %.

41 of 46 new or added lines in 6 files covered. (89.13%)

22 existing lines in 5 files now uncovered.

1509 of 1739 relevant lines covered (86.77%)

24709.24 hits per line